upgrade sdk to 0.11.2 #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neubig
approved these changes
Oct 10, 2022
| @@ -486,12 +485,6 @@ def db_operations(session: ClientSession) -> str: | |||
|
|
|||
| # -- replace things that can't be returned through JSON for now | |||
| system.metric_stats = [] | |||
| for analysis_level in system.system_info.analysis_levels: | |||
There was a problem hiding this comment.
Yay for being able to delete this code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #336
Fixed a couple of breaking changes as documented in #336. I couldn't fix the last one so we need to do DB migration for this PR.
I have prepared the migration scripts and tested them on the dev database. I also tested the scripts on a small subset of the systems in production (around 20 systems) and they worked out fine. By merging this PR, the dev environment would automatically work because the new DB is ready (some systems will be missing if they are submitted from now to the time we deploy this version on dev).
After merging the PR, I will rerun the migration scripts for dev. Then, I will run migration for prod before we deploy to prod.